-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): Persisting tab state for saved query #23087
fix(sqllab): Persisting tab state for saved query #23087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
Codecov Report
@@ Coverage Diff @@
## master #23087 +/- ##
==========================================
+ Coverage 65.70% 65.88% +0.17%
==========================================
Files 1881 1881
Lines 72394 72362 -32
Branches 7882 7874 -8
==========================================
+ Hits 47565 47673 +108
+ Misses 22807 22671 -136
+ Partials 2022 2018 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested locally and was able to repro the bug and confirm the fix works for copying the links
Thanks for the commit @piyush9923 and thanks for the review @Antonio-RiveroMartnez :) |
SUMMARY
When we have multiple tabs opened for saved query, the most recent tab will only have the link preserved while all the other tabs will lose the linkage between saved queries.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
query_parameter_before.mov
After:
query_parameter_after.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION