Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Persisting tab state for saved query #23087

Merged

Conversation

piyush9923
Copy link
Contributor

SUMMARY

When we have multiple tabs opened for saved query, the most recent tab will only have the link preserved while all the other tabs will lose the linkage between saved queries.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

query_parameter_before.mov

After:

query_parameter_after.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #23087 (77579a3) into master (1324135) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 77579a3 differs from pull request most recent head c692aae. Consider uploading reports for the commit c692aae to get more accurate results

@@            Coverage Diff             @@
##           master   #23087      +/-   ##
==========================================
+ Coverage   65.70%   65.88%   +0.17%     
==========================================
  Files        1881     1881              
  Lines       72394    72362      -32     
  Branches     7882     7874       -8     
==========================================
+ Hits        47565    47673     +108     
+ Misses      22807    22671     -136     
+ Partials     2022     2018       -4     
Flag Coverage Δ
hive 52.71% <ø> (?)
mysql 78.26% <ø> (ø)
postgres 78.33% <ø> (ø)
presto 52.61% <ø> (?)
python 78.79% <ø> (+0.35%) ⬆️
sqlite 76.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx 57.48% <ø> (+1.03%) ⬆️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 53.33% <ø> (-1.47%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 56.77% <ø> (ø)
superset/views/sql_lab/views.py 63.81% <ø> (ø)
superset/utils/core.py 88.70% <0.00%> (+0.10%) ⬆️
superset/models/core.py 90.25% <0.00%> (+0.21%) ⬆️
superset/db_engine_specs/base.py 82.12% <0.00%> (+0.46%) ⬆️
superset/connectors/sqla/models.py 89.37% <0.00%> (+1.29%) ⬆️
superset/models/sql_lab.py 74.90% <0.00%> (+1.96%) ⬆️
superset/db_engine_specs/presto.py 87.44% <0.00%> (+7.65%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested locally and was able to repro the bug and confirm the fix works for copying the links

@rusackas rusackas merged commit b92ace4 into apache:master Apr 21, 2023
@rusackas
Copy link
Member

Thanks for the commit @piyush9923 and thanks for the review @Antonio-RiveroMartnez :)

sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants