-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translation): correct translation errors for Chinese(zh) #23129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #23129 +/- ##
=======================================
Coverage 67.54% 67.54%
=======================================
Files 1881 1881
Lines 72396 72396
Branches 7882 7882
=======================================
Hits 48902 48902
Misses 21472 21472
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is my first PR, a review and approval from a maintainer are required. if you know who can review/approval, please ask me to do that. Thanks again! |
SUMMARY
error: translations/zh/LC_MESSAGES/messages.po:8895: positional format placeholders are unbalanced
error: translations/zh/LC_MESSAGES/messages.po:11413: positional format placeholders are unbalanced
error: translations/zh/LC_MESSAGES/messages.po:12046: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:12141: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:12161: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:13408: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:13581: unknown named placeholder 'column_name'
error: translations/zh/LC_MESSAGES/messages.po:13586: unknown named placeholder 'location'
error: translations/zh/LC_MESSAGES/messages.po:14167: placeholders are incompatible
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
No error
TESTING INSTRUCTIONS
apt-get update
apt-get install python3-babel
cd superset
pybabel compile -d translations
ADDITIONAL INFORMATION