Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translation): correct translation errors for Chinese(zh) #23129

Merged
merged 2 commits into from
Apr 5, 2023
Merged

fix(translation): correct translation errors for Chinese(zh) #23129

merged 2 commits into from
Apr 5, 2023

Conversation

zRich
Copy link
Contributor

@zRich zRich commented Feb 20, 2023

SUMMARY

error: translations/zh/LC_MESSAGES/messages.po:8895: positional format placeholders are unbalanced
error: translations/zh/LC_MESSAGES/messages.po:11413: positional format placeholders are unbalanced
error: translations/zh/LC_MESSAGES/messages.po:12046: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:12141: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:12161: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:13408: placeholders are incompatible
error: translations/zh/LC_MESSAGES/messages.po:13581: unknown named placeholder 'column_name'
error: translations/zh/LC_MESSAGES/messages.po:13586: unknown named placeholder 'location'
error: translations/zh/LC_MESSAGES/messages.po:14167: placeholders are incompatible

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
No error

TESTING INSTRUCTIONS

apt-get update
apt-get install python3-babel
cd superset
pybabel compile -d translations

ADDITIONAL INFORMATION

  • Has associated issue: Translation problem with zh #23127
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #23129 (b6365ef) into master (f851e99) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b6365ef differs from pull request most recent head 96a47dd. Consider uploading reports for the commit 96a47dd to get more accurate results

@@           Coverage Diff           @@
##           master   #23129   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files        1881     1881           
  Lines       72396    72396           
  Branches     7882     7882           
=======================================
  Hits        48902    48902           
  Misses      21472    21472           
  Partials     2022     2022           
Flag Coverage Δ
hive 52.76% <0.00%> (ø)
mysql 78.37% <0.00%> (ø)
postgres 78.43% <0.00%> (ø)
presto 52.67% <0.00%> (ø)
python 82.27% <0.00%> (ø)
sqlite 76.90% <0.00%> (ø)
unit 52.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/utils.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zhouyao1994 zhouyao1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zRich
Copy link
Contributor Author

zRich commented Feb 21, 2023

LGTM
@zhouyao1994 thanks for reviewing!

image

This is my first PR, a review and approval from a maintainer are required. if you know who can review/approval, please ask me to do that.

Thanks again!

@rusackas rusackas changed the title correct translation errors for zh chore: correct translation errors for zh Feb 25, 2023
@zRich zRich changed the title chore: correct translation errors for zh fix(translation): correct translation errors for Chinese(zh) Feb 26, 2023
@zRich zRich requested review from zhouyao1994 and rusackas and removed request for zhouyao1994 and rusackas February 26, 2023 14:53
@rusackas rusackas merged commit f0237a5 into apache:master Apr 5, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants