fix(cache): coerce schema_cache_timeout to None #23157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #21827
When a database is created
schema_cache_timeout
property is set to empty string by default insideextra_json
(or at least this is the case for older versions). This leads to the following error when callingget_all_schema_names
which exptects an optional integer. This PR fixes this error.Additionally, these params don't seem to be used in
get_all_schema_names
. So maybe the best course is to remove them all together.TESTING INSTRUCTIONS
Without this, the SQL Lab shows an error when fetching schemas