-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support databend for superset #23308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for Databend! A few minor comments, other than that LGTM 👍
Codecov Report
@@ Coverage Diff @@
## master #23308 +/- ##
==========================================
- Coverage 69.00% 67.49% -1.52%
==========================================
Files 1906 1908 +2
Lines 74149 73598 -551
Branches 8211 7975 -236
==========================================
- Hits 51169 49676 -1493
- Misses 20856 21874 +1018
+ Partials 2124 2048 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 946 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dcc9871
to
26581b9
Compare
Hi @villebro , since this pr has been finished, how about merging this pr? |
Hi @hantmac - I'm so sorry for dropping the ball on this PR. I've merged master on it to restart CI, and will re-review and merge if everything is ok today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fantastic quality of this PR (tests, docs etc) ❤️
@hantmac it seems there's quite a few linting errors here: Would you be able to resolve them? If not I can pick this up and push it through next week. |
Thanks for your review! I will fix it as soon as possible. |
c9725e1
to
aceb37a
Compare
@hantmac I restarted CI, will take a look tomorrow morning PST |
|
||
_time_grain_expressions = { | ||
None: "{col}", | ||
"PT1M": "to_start_of_minute(TO_DATETIME({col}))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use superset.constants.TimeGrain
?
TimeGrain.MINUTE: "to_start_of_minute(TO_DATETIME({col}))",
SUMMARY
Support new database - databend for superset
TESTING INSTRUCTIONS
pytest tests/unit_tests/db_engine_specs/test_databend.py