-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Added SriLanka country map #23338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23338 +/- ##
==========================================
+ Coverage 67.51% 67.58% +0.07%
==========================================
Files 1909 1907 -2
Lines 73465 73530 +65
Branches 7975 7980 +5
==========================================
+ Hits 49601 49697 +96
+ Misses 21816 21785 -31
Partials 2048 2048
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.27.36.209:8080. Credentials are |
@@ -174,6 +175,7 @@ export const countries = { | |||
slovenia, | |||
spain, | |||
sweden, | |||
srilanka, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter seems to be complaining about this PR. It might be that this is not quite in alphabetical order. You can have it (hopefully) auto-fix by running pre-commit run --all-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i will run it and push again.
The test environment isn't working for some reason. Sigh. The pre-commit hook is complaining about formatting. I made a comment above about a hunch I have there. If you could run that and commit the changes, it should allow me to spin up another ephemeral environment for testing. 🤞 |
I have fixed the linting issues, the tests should pass now. @rusackas Please approve the workflow tests to run. |
@rusackas I think the PR is good to merge |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The Sri Lanka country map is not included in the chart country map plugin. This commit adds Sri Lanka map to the chart country map plugin.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION