-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): show_native_filters
leftover
#23389
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23389 +/- ##
==========================================
+ Coverage 67.44% 67.58% +0.13%
==========================================
Files 1907 1907
Lines 73493 73537 +44
Branches 7976 7980 +4
==========================================
+ Hits 49571 49702 +131
+ Misses 21873 21787 -86
+ Partials 2049 2048 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@betodealmeida alternatively, could we bump the export version and create a new import version? |
(cherry picked from commit 0222139)
SUMMARY
#23228 removed
show_native_filters
from dashboards, but it can still be present in exports from older versions. When the key is present, the dashboard is imported correctly, but can't be updated because the schema ofjson_metadata
is now invalid.This PR addresses the problem by removing the field on dashboard import. Additionally, for those dashboards that have already been imported with the field, it relaxes the metadata schema to allow updates when
show_native_filters
is present, removing it before processing the metadata.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION