Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pivot Table v2): resolved full width issue #23393

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

AkashBoora
Copy link
Contributor

SUMMARY

The Pviot Table V2 was not occupying full width when we enlarge in dashboard due to sizing styles. I made some style changes to resolve the issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Pivot Table v2 does not occupy full width of chart box on dashboard #22198
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sfirke
Copy link
Member

sfirke commented Mar 17, 2023

I can't speak to the code but thank you for fixing this!

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #23393 (1f8e81a) into master (da3791a) will not change coverage.
The diff coverage is n/a.

❗ Current head 1f8e81a differs from pull request most recent head adf4bf3. Consider uploading reports for the commit adf4bf3 to get more accurate results

@@           Coverage Diff           @@
##           master   #23393   +/-   ##
=======================================
  Coverage   56.27%   56.27%           
=======================================
  Files        1907     1907           
  Lines       73495    73495           
  Branches     7977     7977           
=======================================
  Hits        41356    41356           
  Misses      30091    30091           
  Partials     2048     2048           
Flag Coverage Δ
javascript 53.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <ø> (ø)
...n-chart-pivot-table/src/react-pivottable/Styles.js 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 832e8fb into apache:master Mar 22, 2023
@rusackas rusackas added the 2.1.1 label Apr 27, 2023
@eschutho eschutho added the v2.1 label May 12, 2023
eschutho pushed a commit to preset-io/superset that referenced this pull request May 23, 2023
eschutho pushed a commit that referenced this pull request May 23, 2023
eschutho pushed a commit that referenced this pull request May 25, 2023
eschutho pushed a commit that referenced this pull request May 31, 2023
@sfirke
Copy link
Member

sfirke commented Jun 23, 2023

Tested and confirmed this works now in 2.1.1rc1! 🎉

@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants