-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lang): update messages.po(t) and add missing German translations #23402
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23402 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 1918 1918
Lines 74151 74151
Branches 8052 8052
=======================================
Hits 50212 50212
Misses 21886 21886
Partials 2053 2053
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CI is failing, can you please address? |
Babel generates unnecessary empty lines just before EOF (see python-babel/babel#799). For now, I removed them manually. Either a comment should be added to CONTRIBUTING.md or |
messages.json should be part of this PR FYI.
That sounds reasonable, can you do one of those? |
This PR now
@nytai I see the latest failing tests as not related to my changes. Could you confirm, please? In case tests are flaky, is there anything which could be done about this? |
I'm currently a bit disappointed by flaky tests blocking review/merging. Please correct me, if I'm wrong @rusackas, but the failing test is not related to this PR, is it? |
@hbruch I restarted the flaked tests, 🤞 they'll pass this time |
Restarted the python integration tests... we'll get this thing through!!! |
@@ -54,4 +54,17 @@ pybabel update \ | |||
-d superset/translations \ | |||
--ignore-obsolete | |||
|
|||
# Chop off last blankline from po/pot files, see https://github.com/python-babel/babel/issues/799 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the extra line causing a problem (e.g. linting issues) or is this just cleanup to feel good about things? Only asking because the other solution might be to tweak the linting rule for these files. This seems fine, I'm just curious. ¯\_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicated empty line was reported by a linting rule, indeed.
feda425
to
ddb69bb
Compare
SUMMARY
This PR
messages.pot
file and derived language dependent*.po
files (generated via./scripts/babel_update.sh
).../de/.../messages.po
fileNOTE: this PR does not (yet) include the
messages.json
files, as I'm hesitant to include them with this PR. They could be generated in the build process and probably should not be checked in anyway. Please let me know, if thede/.../messages.json
or all languages files should be part of this PR.NOTE FURTHER, that there remain some not-yet-localized messages, e.g. the last-modified times in the following screen shot, which are not created localized via helpers.py/changed_on_humanized and created_on_humanized
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION