Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(area chart legacy): tool tip shows actual value rather than y axi… #23469

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

AkashBoora
Copy link
Contributor

SUMMARY

Tha area chart was showing the decimal values when it is expanded mode rather than actula values. I made changes so that it gonna show the actual value rather than decimal values (these decimal values were representing the percentage of value w.r.t total)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot from 2023-03-23 14-20-31
Screenshot from 2023-03-23 14-20-57

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [Chart] Expanded area chart show wrong values in tooltips #20003
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #23469 (efd206f) into master (212b733) will not change coverage.
The diff coverage is n/a.

❗ Current head efd206f differs from pull request most recent head a9dec12. Consider uploading reports for the commit a9dec12 to get more accurate results

@@           Coverage Diff           @@
##           master   #23469   +/-   ##
=======================================
  Coverage   67.64%   67.64%           
=======================================
  Files        1908     1908           
  Lines       73739    73739           
  Branches     7988     7988           
=======================================
  Hits        49879    49879           
  Misses      21814    21814           
  Partials     2046     2046           
Flag Coverage Δ
javascript 53.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/plugins/legacy-preset-chart-nvd3/src/utils.js 15.92% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro merged commit db9ca20 into apache:master Mar 31, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants