fix: Preserves selected scopes when toggling between scope types #23475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23475 +/- ##
==========================================
+ Coverage 67.64% 67.65% +0.01%
==========================================
Files 1908 1910 +2
Lines 73739 73747 +8
Branches 7988 7988
==========================================
+ Hits 49879 49894 +15
+ Misses 21814 21811 -3
+ Partials 2046 2042 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justinpark
reviewed
Mar 28, 2023
| @@ -78,10 +80,13 @@ const FilterScope: FC<FilterScopeProps> = ({ | |||
|
|
|||
| const onUpdateFormValues = useCallback( | |||
| (formValues: any) => { | |||
| if (formScopingType === ScopingType.specific) { | |||
| setLastSpecificScope(formValues.scope); | |||
There was a problem hiding this comment.
I personally prefer to use useRef for this case (since it won't need to re-render)
There was a problem hiding this comment.
Good call! Done.
michael-s-molina
added a commit
to airbnb/superset-fork
that referenced
this pull request
Apr 7, 2023
…che#23475) (cherry picked from commit 80d1e4f)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Preserves selected scopes when toggling between scope types.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-03-23.at.13.54.34.mov
Screen.Recording.2023-03-23.at.13.51.03.mov
TESTING INSTRUCTIONS
Make sure the selected scopes are preserved when toggling between scope types
ADDITIONAL INFORMATION