chore: Adds a tooltip to pre-filter in native filters modal #23481
Conversation
michael-s-molina
requested review from
jinghua-qa,
geido,
eschutho,
rusackas and
betodealmeida
as code owners
Codecov Report
@@ Coverage Diff @@
## master #23481 +/- ##
==========================================
- Coverage 67.65% 67.64% -0.01%
==========================================
Files 1909 1914 +5
Lines 73743 73926 +183
Branches 7987 8020 +33
==========================================
+ Hits 49888 50010 +122
- Misses 21814 21873 +59
- Partials 2041 2043 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -85,6 +85,7 @@ export const nativeFilterTooltips = { | |||
| multipleSelect: 'Allow selecting multiple values', | |||
| defaultValue: | |||
| 'Default value must be set when "Filter value is required" is checked', | |||
| preFilter: `Limits the number of selectable values in a filter. This is useful when you want to display a subset of the column's values either for performance reasons or business rules. Some examples include limiting the number of people displayed to a particular business unit or showing only people registered in the last 90 days.`, | |||
There was a problem hiding this comment.
@michael-s-molina if it's ok with you I might tweak the copy of the this tooltip, i.e., make it more concise.
There was a problem hiding this comment.
No problem @john-bodley. Just suggest an improved copy.
There was a problem hiding this comment.
I agree with @john-bodley , I think this could be less verbose. Could something like this work?
Add filters clauses to control the filter's source query. This is useful when you want to improve the query's performance by only scanning a subset of the underlying data or limit the available values displayed in the filter.
There was a problem hiding this comment.
@michael-s-molina and @villebro I think this is more accurate:
Add filter clauses to control the filter's source query, though only in the context of the autocomplete i.e., these conditions do not impact how the filter is applied to the dashboard. This is useful when you want to improve the query's performance by only scanning a subset of the underlying data or limit the available values displayed in the filter.
There was a problem hiding this comment.
@john-bodley @villebro I updated the text.
mistercrunch
added
🏷️ bot
SUMMARY
Adds a tooltip to pre-filter in native filters modal to better contextualize its use for the users.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that pre-filter exhibits a tooltip.
ADDITIONAL INFORMATION