Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moves CRUD features to src/features #23482

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 24, 2023

SUMMARY

This PR moves CRUD features to src/features according to the results of organizing src/pages discussion.

This work is part of SIP-61

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-03-24 at 11 54 59

TESTING INSTRUCTIONS

1 - Fetch the branch and check the new structure
2 - Make sure everything works as before
3 - Review any possible extensions that may be affected by the refactoring

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #23482 (35dae5d) into master (bc2ec04) will not change coverage.
The diff coverage is 67.64%.

❗ Current head 35dae5d differs from pull request most recent head 8cdac88. Consider uploading reports for the commit 8cdac88 to get more accurate results

@@           Coverage Diff           @@
##           master   #23482   +/-   ##
=======================================
  Coverage   67.68%   67.68%           
=======================================
  Files        1914     1916    +2     
  Lines       73958    73958           
  Branches     8029     8029           
=======================================
  Hits        50060    50060           
  Misses      21852    21852           
  Partials     2046     2046           
Flag Coverage Δ
javascript 53.90% <67.64%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/Datasource/ChangeDatasourceModal.tsx 78.68% <ø> (ø)
...ponents/ReportModal/HeaderReportDropdown/index.tsx 67.50% <ø> (ø)
...src/dashboard/components/PropertiesModal/index.tsx 64.03% <ø> (ø)
...d/src/explore/components/PropertiesModal/index.tsx 50.53% <ø> (ø)
...-frontend/src/features/alerts/AlertReportModal.tsx 54.07% <ø> (ø)
...res/alerts/components/AlertReportCronScheduler.tsx 87.50% <ø> (ø)
...src/features/alerts/components/AlertStatusIcon.tsx 30.55% <ø> (ø)
.../features/alerts/components/NotificationMethod.tsx 50.00% <ø> (ø)
...d/src/features/alerts/components/RecipientIcon.tsx 33.33% <ø> (ø)
...tend/src/features/allEntities/AllEntitiesTable.tsx 0.00% <ø> (ø)
... and 70 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Mr Clean says Thank you!

image

@michael-s-molina
Copy link
Member Author

LGTM, Mr Clean says Thank you!

Nice one! 🤣

Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for organization

Copy link
Member

@jfrag1 jfrag1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit adcb8cf into apache:master Apr 6, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants