Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-generator): Addresses linter errors in newly generated Superset plugin #23513

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

alex-bain
Copy link
Contributor

SUMMARY

When creating a new Superset plugin using the plugin generator, the generated code contains linter errors that prevent Superset from building properly. This PR updates the generator erb templates so that they do not contain linter errors.

Note: Plugins with very long names may still generate linter errors, due to excessive line length

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

default-plugin-linter-errors

After:

(Build completes without errors)

TESTING INSTRUCTIONS

  • Create a new plugin using the Superset plugin generator in the superset-frontend/plugins/ directory
  • Run npm run build from the superset-frontend directory
  • Confirm that build completes without linter errors (pre-existing warnings have not been addressed)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai merged commit de42c11 into apache:master Mar 30, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants