-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(word cloud): series label format fixed for custom sql queries #23517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Please use getColumnLabel
function getSeriesLabel( | ||
series: LegacyWordCloudFormData['series'], | ||
): string | undefined { | ||
if (typeof series === 'string' || typeof series === 'undefined') { | ||
return series; | ||
} | ||
|
||
return series.label; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a very similar fix yesterday to the Heatmap plugin. Please check the getColumnLabel
util and how it can be used here: #23507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing me to the util function! I have made the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! 🎉
Codecov Report
@@ Coverage Diff @@
## master #23517 +/- ##
==========================================
+ Coverage 67.63% 67.64% +0.01%
==========================================
Files 1910 1914 +4
Lines 73746 73926 +180
Branches 7987 8020 +33
==========================================
+ Hits 49878 50010 +132
- Misses 21826 21873 +47
- Partials 2042 2043 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fix(word cloud) - issue #19975 - series label format fixed for custom sql queries
SUMMARY
This is a fix for issue
#19975
For custom sql queries the type of series field is different from string. Made changes to the interface LegacyWordCloudFormData interface and series label in encoding.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION