fix(plugin-chart-table): Include time control #23533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The "Include time" control in Table chart is not working properly when GENERIC_CHART_AXES is enabled because of lack of the time column in chart settings.
This PR removes the
include_time
checkbox and ifinclude_time
was true before andgranularity_sqla
was set, it moves thegranularity_sqla
column to dimensions. The end result is the same as with the checkbox, except that the label of the time column is actual column name rather than "Time".BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION