fix: Hide FilterBar for Reports #23543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23543 +/- ##
==========================================
- Coverage 67.68% 67.68% -0.01%
==========================================
Files 1914 1914
Lines 73958 73947 -11
Branches 8029 8030 +1
==========================================
- Hits 50060 50048 -12
Misses 21852 21852
- Partials 2046 2047 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kgabryje
reviewed
Mar 31, 2023
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 31, 2023
| @@ -655,18 +658,17 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => { | |||
| > | |||
| <StickyPanel ref={containerRef} width={filterBarWidth}> | |||
| <ErrorBoundary> | |||
| {!isReport && ( | |||
There was a problem hiding this comment.
We have a few places where we set margins for dashboard so that filter bar fits nicely (such as lines 541 or 628). Should we set them to 0 for reports? Or are they not visible when filter bar is hidden?
eschutho
reviewed
Mar 31, 2023
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Show resolved
Hide resolved
eschutho
approved these changes
Mar 31, 2023
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 10, 2023
(cherry picked from commit a18e33b)
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR #22614 introduced an issue for which the reports would not be able to execute when a filter of the FilterBar required immediate execution (see for example filters with first filter value selected by default). The reason is that the logics that run the filters are often encapsulated within the rendering of the component. By removing the rendering of the FilterBar those filters failed to execute causing the reports to fail.
This PR introduces an additional way to hide the FilterBar through the
hiddenproperty, which effectively only hides the FilterBar with CSS while still rendering it. While not an optimal solution, this will unblock the reports. A more in-depth refactor is required to decouple the logics of the filters from the rendering of the component.TESTING INSTRUCTIONS
standalone=3in the urlADDITIONAL INFORMATION