Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove wrong information from the Alerts & Reports docs #23544

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

geido
Copy link
Member

@geido geido commented Mar 31, 2023

SUMMARY

The docs were referring to ALERT_REPORTS_NOTIFICATION_DRY_RUN = True in cofing.py, which isn't the case. In fact, the config.py sets ALERT_REPORTS_NOTIFICATION_DRY_RUN to False by default. Additionally the REDIS_HOST was referring to redis-superset but the Docker publishes superset_cache instead.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #23544 (6d0710a) into master (bc2ec04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23544   +/-   ##
=======================================
  Coverage   67.68%   67.68%           
=======================================
  Files        1914     1914           
  Lines       73958    73958           
  Branches     8029     8029           
=======================================
  Hits        50060    50060           
  Misses      21852    21852           
  Partials     2046     2046           
Flag Coverage Δ
hive 52.73% <ø> (ø)
javascript 53.90% <ø> (ø)
mysql 78.47% <ø> (ø)
postgres 78.55% <ø> (ø)
presto 52.66% <ø> (ø)
python 82.39% <ø> (ø)
sqlite 77.05% <ø> (ø)
unit 52.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 08375ca into master Apr 4, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/update-docs branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants