-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tags features flag on base models #23548
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23548 +/- ##
==========================================
- Coverage 67.71% 65.91% -1.80%
==========================================
Files 1914 1914
Lines 73994 73984 -10
Branches 8033 8030 -3
==========================================
- Hits 50103 48769 -1334
- Misses 21841 23165 +1324
Partials 2050 2050
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 89 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7f6c4a5
to
af5669e
Compare
acbe921
to
6b30d2d
Compare
f0bf646
to
e38c9d7
Compare
SUMMARY
in preset, we are experiencing issues with tags being referenced in the "Edit properties" pages. We aren't able to reproduce locally but think on app load something is going on with the model being able to reference tags, and isn't being passed properly through the api even though the flag is enabled. So softening the feature flag conditions at the model should help alleviate this.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION