Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tags features flag on base models #23548

Merged
merged 12 commits into from
Apr 4, 2023
Merged

fix: tags features flag on base models #23548

merged 12 commits into from
Apr 4, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 31, 2023

SUMMARY

in preset, we are experiencing issues with tags being referenced in the "Edit properties" pages. We aren't able to reproduce locally but think on app load something is going on with the model being able to reference tags, and isn't being passed properly through the api even though the flag is enabled. So softening the feature flag conditions at the model should help alleviate this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #23548 (8802f8e) into master (cdc7af1) will decrease coverage by 1.80%.
The diff coverage is 100.00%.

❗ Current head 8802f8e differs from pull request most recent head 2e94740. Consider uploading reports for the commit 2e94740 to get more accurate results

@@            Coverage Diff             @@
##           master   #23548      +/-   ##
==========================================
- Coverage   67.71%   65.91%   -1.80%     
==========================================
  Files        1914     1914              
  Lines       73994    73984      -10     
  Branches     8033     8030       -3     
==========================================
- Hits        50103    48769    -1334     
- Misses      21841    23165    +1324     
  Partials     2050     2050              
Flag Coverage Δ
hive ?
mysql 78.49% <100.00%> (+<0.01%) ⬆️
postgres 78.57% <100.00%> (+<0.01%) ⬆️
presto ?
python 78.70% <100.00%> (-3.71%) ⬇️
sqlite 77.07% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 91.51% <ø> (-0.06%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 55.01% <ø> (-0.16%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 62.33% <ø> (-2.30%) ⬇️
superset/models/dashboard.py 78.16% <100.00%> (+0.29%) ⬆️
superset/models/slice.py 87.20% <100.00%> (+0.41%) ⬆️
superset/models/sql_lab.py 73.04% <100.00%> (-1.67%) ⬇️

... and 89 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh force-pushed the tags-fix branch 3 times, most recently from 7f6c4a5 to af5669e Compare April 3, 2023 21:58
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 3, 2023
@hughhhh hughhhh force-pushed the tags-fix branch 2 times, most recently from acbe921 to 6b30d2d Compare April 4, 2023 00:48
@hughhhh hughhhh force-pushed the tags-fix branch 2 times, most recently from f0bf646 to e38c9d7 Compare April 4, 2023 03:09
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 4, 2023
@hughhhh hughhhh merged commit a4d4084 into master Apr 4, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the tags-fix branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants