Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QueryParamProvider error on backend rendered views #23567

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes the following QueryParamProvider error on backend rendered views:

LocationProvider.js?e373:13 Uncaught Error: useQueryParams must be used within a QueryParamProvider
    at useLocationContext (LocationProvider.js?e373:13:1)
    at useQueryParams (useQueryParams.js?5bf2:71:1)
    at RightMenuWithQueryWrapper (RightMenu.tsx?e833:571:1)
    at renderWithHooks (react-dom.development.js?61bb:14804:1)
    at mountIndeterminateComponent (react-dom.development.js?61bb:17483:1)
    at beginWork (react-dom.development.js?61bb:18597:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js?61bb:189:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?61bb:238:1)
    at invokeGuardedCallback (react-dom.development.js?61bb:293:1)
    at beginWork$1 (react-dom.development.js?61bb:23204:1)

TESTING INSTRUCTIONS

Make sure the error does not appear on backend rendered pages such as login, list of users, list of roles, etc.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #23567 (3c04bac) into master (cdc7af1) will not change coverage.
The diff coverage is n/a.

❗ Current head 3c04bac differs from pull request most recent head 5d43f86. Consider uploading reports for the commit 5d43f86 to get more accurate results

@@           Coverage Diff           @@
##           master   #23567   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        1914     1914           
  Lines       73994    73994           
  Branches     8033     8033           
=======================================
  Hits        50103    50103           
  Misses      21841    21841           
  Partials     2050     2050           
Flag Coverage Δ
javascript 53.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/menu.tsx 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 61e71bb into apache:master Apr 4, 2023
michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants