fix: Disables email reports for unsaved charts

[michael-s-molina]

SUMMARY

Changes the Email report functionality in Explore to behave in the same way as the dashboards and only allow editing after a chart is saved. Previously, the user could try to setup an email report but would face many errors because many parts of the feature depend on the saved state.

It improves rendering by returning the same instance of an empty report, used in useEffect, when there's none in the Redux store.

It also creates an specific DELETE_REPORT action to clearly separate the logic and avoid unnecessary queries.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-05.at.11.42.15.mov

Screen.Recording.2023-04-05.at.11.36.05.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23588 (9bb93db) into master (117360c) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

❗ Current head 9bb93db differs from pull request most recent head 40453a8. Consider uploading reports for the commit 40453a8 to get more accurate results

@@            Coverage Diff             @@
##           master   #23588      +/-   ##
==========================================
- Coverage   67.72%   67.71%   -0.01%     
==========================================
  Files        1916     1916              
  Lines       74029    74039      +10     
  Branches     8040     8041       +1     
==========================================
+ Hits        50135    50137       +2     
- Misses      21846    21852       +6     
- Partials     2048     2050       +2     

Flag	Coverage Δ
javascript	53.95% <55.55%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/reports/reducers/reports.js	33.33% <0.00%> (-4.77%)	⬇️
superset-frontend/src/reports/actions/reports.js	41.17% <50.00%> (+1.78%)	⬆️
...ponents/ReportModal/HeaderReportDropdown/index.tsx	64.28% <66.66%> (-3.22%)	⬇️
...rset-frontend/src/components/ReportModal/index.tsx	79.03% <66.66%> (+0.69%)	⬆️
superset-frontend/src/views/CRUD/hooks.ts	47.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more