fix(charts): Time range filters are not being applied to charts that were overwritten

[Antonio-RiveroMartnez]

SUMMARY

When GENERIC_CHART_AXES FF is on and we overwrite a chart, any filter coming from the dashboard is not saved (it gets removed since its marked as isExtra). However, removing such filter doesn't have to mean we delete the original temporal filter if any, otherwise the dashboard wont be able to filter the chart again.

This PR keeps the original adhoc_filters from the slice so when calling the PUT API it doesn't get removed. So any call to api/v1/dashboard/{db_id}/charts is consistent even after you overwrite the chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Make sure GENERIC_CHART_AXES FF is ON
2. Create a chart and add it to a dashboard.
3. Add a time range filter to the dashboard and apply any value.
4. Click on the chart title to access it in the Chart Builder menu.
5. Overwrite the chart (no changes are needed).
6. Go back to the dashboard, and apply any time range filter.
7. The filter must keep working after overwriting the chart

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: GENERIC_CHART_AXES
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23589 (ccfc2d1) into master (117360c) will increase coverage by 0.00%.
The diff coverage is 65.75%.

❗ Current head ccfc2d1 differs from pull request most recent head 252ff04. Consider uploading reports for the commit 252ff04 to get more accurate results

@@           Coverage Diff           @@
##           master   #23589   +/-   ##
=======================================
  Coverage   67.72%   67.73%           
=======================================
  Files        1916     1916           
  Lines       74029    74056   +27     
  Branches     8040     8040           
=======================================
+ Hits        50135    50159   +24     
- Misses      21846    21849    +3     
  Partials     2048     2048           

Flag	Coverage Δ
javascript	53.97% <68.75%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t-frontend/src/dashboard/reducers/nativeFilters.ts	39.28% <0.00%> (-1.46%)	⬇️
...et-frontend/src/dashboard/actions/nativeFilters.ts	42.55% <33.33%> (+0.16%)	⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	63.81% <33.33%> (+0.18%)	⬆️
superset/db_engine_specs/bigquery.py	69.54% <45.45%> (-0.18%)	⬇️
superset/utils/csv.py	96.66% <50.00%> (-1.61%)	⬇️
superset/views/core.py	74.75% <88.88%> (+0.16%)	⬆️
...t-frontend/src/explore/actions/saveModalActions.js	98.75% <100.00%> (+1.41%)	⬆️
superset/charts/commands/export.py	94.11% <100.00%> (ø)
superset/charts/post_processing.py	90.00% <100.00%> (+0.21%)	⬆️
...erset/dashboards/commands/importers/v1/__init__.py	98.63% <100.00%> (+0.10%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[eschutho]

LGTM!

[geido]

/testenv up FEATURE_GENERIC_CHART_AXES=true

[github-actions]

@geido Ephemeral environment spinning up at http://34.211.159.8:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[justinpark]

@Antonio-RiveroMartnez There's a regression from this change.
With this change, user cannot remove the applied adhoc_filters. (Please see the following video. It keeps reverting back the filter option)

adhoc_filters.regression.mov

[Antonio-RiveroMartnez]

Hey @justinpark thanks for letting me know. I will have a look as soon as possible 😎