Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN #23604

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

nytai
Copy link
Member

@nytai nytai commented Apr 6, 2023

SUMMARY

Let's make it clearer that dry run is enabled. Many people interpret the current message to mean that the notification was sent.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #23604 (f0eff23) into master (c5eecc7) will decrease coverage by 0.03%.
The diff coverage is 60.89%.

❗ Current head f0eff23 differs from pull request most recent head f41e26d. Consider uploading reports for the commit f41e26d to get more accurate results

@@            Coverage Diff             @@
##           master   #23604      +/-   ##
==========================================
- Coverage   67.72%   67.70%   -0.03%     
==========================================
  Files        1916     1918       +2     
  Lines       74051    74133      +82     
  Branches     8040     8052      +12     
==========================================
+ Hits        50153    50193      +40     
- Misses      21850    21887      +37     
- Partials     2048     2053       +5     
Flag Coverage Δ
hive 52.73% <38.27%> (-0.02%) ⬇️
mysql 78.51% <83.95%> (+0.02%) ⬆️
postgres 78.59% <83.95%> (+0.02%) ⬆️
presto 52.66% <38.27%> (-0.02%) ⬇️
python 82.43% <83.95%> (+0.01%) ⬆️
sqlite 77.10% <83.95%> (+0.02%) ⬆️
unit 52.63% <43.20%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-echarts/src/Funnel/transformProps.ts 72.34% <ø> (ø)
...s/plugin-chart-echarts/src/Graph/transformProps.ts 72.36% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.71% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 58.33% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 88.48% <ø> (ø)
...rc/components/Datasource/ChangeDatasourceModal.tsx 78.68% <ø> (ø)
...rset-frontend/src/components/ListView/ListView.tsx 93.75% <ø> (ø)
...src/dashboard/components/PropertiesModal/index.tsx 64.03% <ø> (ø)
... and 109 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

self._report_schedule.name,
recipient.recipient_config_json,
app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this not produce True is enabled, set it to False to send notifications., as that's the value of the config param, not it's name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought I pushed a fix for that 😞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... I pushed to the wrong remote. Fixed

@nytai nytai requested a review from villebro April 6, 2023 22:33
@rusackas rusackas merged commit 350723b into master Apr 12, 2023
@rusackas rusackas deleted the tai/fix-report-dry-run branch April 12, 2023 15:30
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants