-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: nvm error while local setup #23609
docs: nvm error while local setup #23609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinpark @michael-s-molina @villebro @rusackas @eschutho @geido i have added one change to documentation, at the point where nvm install instructions was there (Issue that i was facing while usage so that if anyone else has similar issue can resolve) Can you please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you can try this curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash
Yes this one is working. Maybe due to version specified in documentation i had error. But i don't think we can change version by ourselves. When i used the one that was specified in documentation, it was installing but not loading nvm. Thats why i mentioned if you have used curl command to install nvm but nvm is not loaded and still shows nvm: command not found, then you can use what i mentioned in this PR (to complete nvm installation documentation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Approved the PR, and running CI. Nag me if it gets stuck or of I forget to circle back to merge it ;) |
Did documentation changes, so that people getting similar type of problem while local setup that i got (by following documentation) can easily identify.