Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: nvm error while local setup #23609

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

Abhishek-kumar-samsung
Copy link
Contributor

Did documentation changes, so that people getting similar type of problem while local setup that i got (by following documentation) can easily identify.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@Abhishek-kumar-samsung
Copy link
Contributor Author

@justinpark @michael-s-molina @villebro @rusackas @eschutho @geido i have added one change to documentation, at the point where nvm install instructions was there (Issue that i was facing while usage so that if anyone else has similar issue can resolve)

Can you please review.

@Abhishek-kumar-samsung Abhishek-kumar-samsung changed the title nvm error while local setup docs: nvm error while local setup Apr 7, 2023
Copy link
Contributor

@ved-kashyap-samsung ved-kashyap-samsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can try this curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash

@Abhishek-kumar-samsung
Copy link
Contributor Author

Abhishek-kumar-samsung commented Apr 10, 2023

Or you can try this curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash

Yes this one is working. Maybe due to version specified in documentation i had error. But i don't think we can change version by ourselves.

When i used the one that was specified in documentation, it was installing but not loading nvm. Thats why i mentioned if you have used curl command to install nvm but nvm is not loaded and still shows nvm: command not found, then you can use what i mentioned in this PR (to complete nvm installation documentation).

Copy link
Contributor

@ved-kashyap-samsung ved-kashyap-samsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rusackas
Copy link
Member

Approved the PR, and running CI. Nag me if it gets stuck or of I forget to circle back to merge it ;)

@rusackas rusackas merged commit 240b292 into apache:master Apr 13, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@Abhishek-kumar-samsung Abhishek-kumar-samsung deleted the nvm_not_installed branch January 13, 2024 18:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants