fix: Increases the options limit for Annotation Layers

[michael-s-molina]

SUMMARY

Increases the options limit for Annotation Layers in Explore. Previously, the options were limited to 20 results which is a problem for organizations with many records. Following the same pattern used in filters, the limit was increased to a 1000 values. Although, 1000 values will probably be sufficient for most of organizations, the endgame solution would be to create a control using the AsyncSelect and replace the sync version. This change is not in the scope of this PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Make sure the Annotation Layers select in Explore can show up to a 1000 values.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[Antonio-RiveroMartnez]

LGTM!

[Vitor-Avila]

hey @michael-s-molina @rusackas I was testing this change, and on my end the amount of returned results is 100 (rather than 1000). In my tests, regardless if I increase the page size in the request arguments, it seems that Superset has a max size defined in the server side.

Do you know if this server side limit is configureable and could be changed? It could be an additional modification needed on my end. Currently I see this server-side hard limit of 100 to most API endpoints (charts, annotation layers, dashboards, datasets, etc).

[michael-s-molina]

Do you know if this server side limit is configureable and could be changed?

The only one I can think of is FAB_API_MAX_PAGE_SIZE.

[Vitor-Avila]

ohh, I see -- thanks for sharing!