-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Zero values on Dual Line axis bounds #23649
fix: Zero values on Dual Line axis bounds #23649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23649 +/- ##
==========================================
+ Coverage 67.93% 68.08% +0.15%
==========================================
Files 1918 1920 +2
Lines 73891 73984 +93
Branches 8058 8092 +34
==========================================
+ Hits 50199 50374 +175
+ Misses 21633 21539 -94
- Partials 2059 2071 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a minor suggestion (??) but it looks okay
(cherry picked from commit d66e6e6)
(cherry picked from commit d66e6e6)
SUMMARY
Fix a bug that prevented a user from using zero values on Dual Line chart axis bounds.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-04-11.at.14.20.56.mov
Screen.Recording.2023-04-11.at.14.16.58.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION