Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): Only attempt to drop types if they exist #23650

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Apr 11, 2023

SUMMARY

If the database is fully upgraded, then downgraded past this migration, re-upgrading will fail because the migration is trying to drop a type that does not exist.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jfrag1 jfrag1 requested a review from a team as a code owner April 11, 2023 17:27
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #23650 (de4fee7) into master (825006d) will not change coverage.
The diff coverage is n/a.

❗ Current head de4fee7 differs from pull request most recent head 190332f. Consider uploading reports for the commit 190332f to get more accurate results

@@           Coverage Diff           @@
##           master   #23650   +/-   ##
=======================================
  Coverage   67.93%   67.93%           
=======================================
  Files        1918     1918           
  Lines       73891    73891           
  Branches     8058     8058           
=======================================
  Hits        50199    50199           
  Misses      21633    21633           
  Partials     2059     2059           
Flag Coverage Δ
hive 53.16% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
python 83.03% <ø> (ø)
sqlite 77.78% <ø> (ø)
unit 53.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jfrag1 jfrag1 closed this Apr 11, 2023
@jfrag1 jfrag1 reopened this Apr 11, 2023
@jfrag1 jfrag1 closed this Apr 11, 2023
@jfrag1 jfrag1 reopened this Apr 11, 2023
@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit 61ddfe6 into apache:master Apr 11, 2023
@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the jack/migration-only-drop-type-if-exists branch April 11, 2023 19:04
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants