Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Further drill by in Pivot Table #23692

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

Due to faulty logic in Pivot Table, the right click actions were available only when cross filtering was available. That prevented applying further drill by in the drill by modal, because cross filtering is not available in the modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested to work as expected. What a 🤯 feeling to drill into a pivot table 😄

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #23692 (4053c85) into master (240b292) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 4053c85 differs from pull request most recent head b6bd8b1. Consider uploading reports for the commit b6bd8b1 to get more accurate results

@@            Coverage Diff             @@
##           master   #23692      +/-   ##
==========================================
- Coverage   68.09%   68.09%   -0.01%     
==========================================
  Files        1922     1922              
  Lines       74041    74042       +1     
  Branches     8101     8102       +1     
==========================================
  Hits        50419    50419              
- Misses      21551    21552       +1     
  Partials     2071     2071              
Flag Coverage Δ
javascript 54.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...ivot-table/src/react-pivottable/TableRenderers.jsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit da5f715 into apache:master Apr 14, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants