fix(filters): Stop breaking if translateToSql returns an object

[Antonio-RiveroMartnez]

SUMMARY

There might be times where after changing the dataset, the translateToSql is not just a string but an object and thus you get an error when trying to perform the substring operation. In that case we need to get the label from the column_name if present if not just return an empty string instead.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Load a BigNumber chart
2. Swap the dataset to be something that has a time filter like Vehicle Sales in the examples DB
3. Change the chart type to be area chart
4. You should not get an error, instead, the filters should be populated using the new dataset info

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

Do I understand correctly that the bug occurs when adhocFIlter.subject is an object and not a string? If so, maybe we could move the logic of extracting column_name to getSimpleSQLExpression, line 298 - let expression = subject ?? '';?

[kgabryje]

Lgtm

[codecov]

Codecov Report

Merging #23715 (280894c) into master (9681d85) will increase coverage by 0.00%.
The diff coverage is 52.00%.

❗ Current head 280894c differs from pull request most recent head 41c4a07. Consider uploading reports for the commit 41c4a07 to get more accurate results

@@           Coverage Diff           @@
##           master   #23715   +/-   ##
=======================================
  Coverage   68.18%   68.19%           
=======================================
  Files        1941     1941           
  Lines       75241    75242    +1     
  Branches     8158     8157    -1     
=======================================
+ Hits        51306    51308    +2     
+ Misses      21852    21851    -1     
  Partials     2083     2083           

Flag	Coverage Δ
javascript	54.49% <52.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx	50.00% <50.00%> (+0.52%)	⬆️
...uperset-frontend/src/explore/exploreUtils/index.js	78.76% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more