chore(chart-data): add post processing error message to response #23734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When calling the chart data endpoint with an incorrect post processing operation, the error would get swallowed due to the reraised exception not containing a message. This adds that message from the original exception. I also checked that this was the only instance where a
QueryObjectValidationError
was not passing on a message, either a new one or the one from the original exception. We also add a test that would previously have failed due to the response being a 200 without the error message.AFTER
Now the 400 response of the incorrect request tells what the issue is:
BEFORE
Previously the message was swallowed along with a 200 status code:
ADDITIONAL INFORMATION