fix(ace-editor): use monospace fonts by default #23747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
|
@villebro Container image not yet published for this PR. Please try again when build is complete. |
|
@villebro Ephemeral environment creation failed. Please check the Actions logs for details. |
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the adhoc popovers use a non-monospaced font on Safari, causing misplaced cursors when the statement contains bolded elements. This was not an issue in SQL Lab, which applied a custom font family. This PR moves the SQL Lab font family config into the main ACE Editor component, ensuring that all editors have the same font family.
AFTER
Now the bolded elements no longer cause the cursor to lag behind:
ace-after.mp4
SQL Lab is unchanged:
BEFORE
Before the cursor would fall behind when there were bolded elements in the statement:
ace-before.mp4
SQL Lab before:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION