Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display both queries result in Table mode for Mixed Chart in drill by modal #23768

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR enables displaying result tables for both queries of Mixed Chart in Table mode in drill by modal

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kgabryje kgabryje force-pushed the feat/drill-by-table-all-queries branch from 0195f82 to 210c0b1 Compare April 21, 2023 14:32
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #23768 (4904a97) into master (764c3c9) will increase coverage by 0.00%.
The diff coverage is 91.66%.

❗ Current head 4904a97 differs from pull request most recent head 210c0b1. Consider uploading reports for the commit 210c0b1 to get more accurate results

@@           Coverage Diff           @@
##           master   #23768   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files        1924     1925    +1     
  Lines       74381    74389    +8     
  Branches     8106     8108    +2     
=======================================
+ Hits        50486    50494    +8     
  Misses      21818    21818           
  Partials     2077     2077           
Flag Coverage Δ
javascript 54.10% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/components/Chart/DrillBy/DrillByModal.tsx 72.54% <50.00%> (-0.53%) ⬇️
...c/components/Chart/DrillBy/useResultsTableView.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit b734a0f into apache:master Apr 21, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants