Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix deprecation warnings for SQLALchemy URL #23770

Merged
merged 1 commit into from
May 11, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

SQLAlchemy URL() is deprecated since SQLAlchemy 1.4 in favor of URL.create()

TESTING INSTRUCTIONS

pytest or ./scripts/tests/run.sh

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #23770 (4678d7d) into master (e3719a1) will increase coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 4678d7d differs from pull request most recent head c241adc. Consider uploading reports for the commit c241adc to get more accurate results

@@            Coverage Diff             @@
##           master   #23770      +/-   ##
==========================================
+ Coverage   68.13%   68.22%   +0.08%     
==========================================
  Files        1941     1941              
  Lines       75304    75304              
  Branches     8166     8166              
==========================================
+ Hits        51308    51373      +65     
+ Misses      21907    21842      -65     
  Partials     2089     2089              
Flag Coverage Δ
hive 53.18% <0.00%> (?)
mysql 78.91% <0.00%> (ø)
postgres 78.98% <0.00%> (ø)
presto 53.10% <0.00%> (ø)
python 82.75% <0.00%> (+0.17%) ⬆️
sqlite 77.51% <0.00%> (ø)
unit 53.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/base.py 90.82% <ø> (ø)
superset/db_engine_specs/clickhouse.py 54.87% <0.00%> (ø)
superset/db_engine_specs/databricks.py 70.42% <ø> (ø)
superset/db_engine_specs/snowflake.py 67.25% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 0788b5f into apache:master May 11, 2023
@sebastianliebscher sebastianliebscher deleted the chore_sqlalchemy_url branch May 11, 2023 08:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants