fix: superset db upgrade not working due to removal of FLAGS variable… #23771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In superset/sql_parse.py sqlparse.keywords.FLAGS is used.
However, sqlparse has removed the FLAGS variable from the code sqlparse/kewords.py.
This leads to an AttributeError when running the CLI command
This PR fixes that by replacing the sqlparse.keywords.FLAGS variable in sql_parse.py with the value originally defined in sqlparse.keywords.FLAGS.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Fixes #23742