Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: superset db upgrade not working due to removal of FLAGS variable… #23771

Closed
wants to merge 1 commit into from

Conversation

LeonardSchuler
Copy link

SUMMARY

In superset/sql_parse.py sqlparse.keywords.FLAGS is used.
However, sqlparse has removed the FLAGS variable from the code sqlparse/kewords.py.

This leads to an AttributeError when running the CLI command

$ superset db upgrade
AttributeError: module 'sqlparse.keywords' has no attribute 'FLAGS'

This PR fixes that by replacing the sqlparse.keywords.FLAGS variable in sql_parse.py with the value originally defined in sqlparse.keywords.FLAGS.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Fixes #23742

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@Zander-1024
Copy link

emmmmm

@EugeneTorap EugeneTorap mentioned this pull request May 23, 2023
9 tasks
@EugeneTorap
Copy link
Contributor

superseded by #24045

@villebro
Copy link
Member

Thanks for the fix @LeonardSchuler - as this has been superseded by #24045, we can close this PR.

@villebro villebro closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

superset db upgrade not working due to removal of FLAGS variable in sqlparse/kewords.py
4 participants