Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: discourage the use of SQLite #23794

Merged
merged 2 commits into from
Apr 26, 2023
Merged

docs: discourage the use of SQLite #23794

merged 2 commits into from
Apr 26, 2023

Conversation

dpgaspar
Copy link
Member

SUMMARY

Make docs more explicit that using a SQLite metadata DB is highly not advisable.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina reviewed Apr 24, 2023
View reviewed changes
docs/docs/installation/configuring-superset.mdx
Comment on lines +77 to +78
It's important to use only the supported database engines and consider using a different
database engine on a separate host or container.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's important to use only the supported database engines and consider using a different
database engine on a separate host or container.
We recommend using another supported database engine on a separate host or container.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shorter but seems a bit confusing to say "another supported database engine on a separate host"

@dpgaspar dpgaspar merged commit e805dec into apache:master Apr 26, 2023
@dpgaspar dpgaspar deleted the docs/sqlite-metadata branch April 26, 2023 13:28
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@dpgaspar @sebastianliebscher
docs: discourage the use of SQLite (apache#23794)
633558e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @michael-s-molina @mistercrunch