Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): test failed due to legacy api url #23805

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Apr 25, 2023

SUMMARY

Following unit test failed due to #22916
It's because the test uses the legacy api endpoint but the api is migrated to new endpoint

It looks like the PR made and passed CI before the api migration completed.

This commit fixes the test code to pass the CI

FAIL src/SqlLab/components/ExploreCtasResultsButton/ExploreCtasResultsButton.test.tsx (5.404 s)
  ● Console
    console.warn
      Unmatched POST to http://localhost/api/v1/dataset/get_or_create/

      178 |   }
      179 |
    > 180 |   return fetchWithRetry(url, request);
          |          ^
      181 | }
      182 |

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #23805 (90bda90) into master (742c2cd) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 90bda90 differs from pull request most recent head 4f975ef. Consider uploading reports for the commit 4f975ef to get more accurate results

@@            Coverage Diff             @@
##           master   #23805      +/-   ##
==========================================
+ Coverage   67.98%   68.02%   +0.03%     
==========================================
  Files        1936     1936              
  Lines       74928    74929       +1     
  Branches     8140     8141       +1     
==========================================
+ Hits        50942    50970      +28     
+ Misses      21894    21871      -23     
+ Partials     2092     2088       -4     
Flag Coverage Δ
javascript 54.28% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit 7e4be7d into apache:master Apr 25, 2023
@ebaratte ebaratte mentioned this pull request Apr 26, 2023
9 tasks
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants