Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revert): Reverts storybook-addon-mock inclusion #23818

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Many of our stories in Storybook are throwing errors. After intensive investigation and the help of git bisect, I was able track the inclusion of storybook-addon-mock dependency in #23429 as the root cause for the errors. I investigated for a couple of hours to understand the reason why it was generating the errors but I wasn't able to resolve the issue. During the investigation I found that there is an open issue with the addon that also need to be addressed. Given that this is affecting many stories, this PR reverts that dependency to give us time to further investigate the problem without blocking Storybook development.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-04-25 at 14 41 07

TESTING INSTRUCTIONS

Make sure the errors above don't happen.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #23818 (539d9c0) into master (7e4be7d) will increase coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 539d9c0 differs from pull request most recent head 644f033. Consider uploading reports for the commit 644f033 to get more accurate results

@@            Coverage Diff             @@
##           master   #23818      +/-   ##
==========================================
+ Coverage   68.00%   68.01%   +0.01%     
==========================================
  Files        1936     1937       +1     
  Lines       74929    74936       +7     
  Branches     8141     8141              
==========================================
+ Hits        50955    50970      +15     
+ Misses      21886    21878       -8     
  Partials     2088     2088              
Flag Coverage Δ
javascript 54.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...metadataBar/DatasetMetadataBar.skipped-stories.tsx 0.00% <ø> (ø)
superset/row_level_security/schemas.py 100.00% <ø> (ø)
superset/row_level_security/commands/update.py 91.66% <50.00%> (ø)
superset/row_level_security/commands/create.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 09bd40b into apache:master Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants