Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add logging events for drill by #23854

Merged
merged 1 commit into from
Apr 28, 2023
Merged

chore: Add logging events for drill by #23854

merged 1 commit into from
Apr 28, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR adds logging for following events:

  • drill by modal is first opened
  • further drill by is performed (depth of drilling added to the log)
  • Edit chart is clicked
  • Breadcrumb is clicked

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje merged commit 0738183 into apache:master Apr 28, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@kgabryje @sebastianliebscher
chore: Add logging events for drill by (apache#23854)
98a2ba7
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilykuang lilykuang lilykuang approved these changes

@eschutho eschutho Awaiting requested review from eschutho

@yousoph yousoph Awaiting requested review from yousoph

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgabryje @lilykuang @mistercrunch