-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move dynamic schema out of base Postgres class #23868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23868 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 1938 1938
Lines 74972 74972
Branches 8141 8141
=======================================
Hits 51067 51067
Misses 21826 21826
Partials 2079 2079
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset/db_engine_specs/postgres.py
Outdated
) | ||
return schemas[0] | ||
|
||
options = re.split(r"-c\s?", connect_args.get("options", "")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can actually get rid of the get_schema_from_engine_params
method here, since Redshift doesn't support passing search_path
as far as I could see.
@hughhhh or @betodealmeida Netezza, snowflake, hana and vertica also are based from the |
this is basically a revert on what current functionality, instead of having i can write a test to verify this |
(cherry picked from commit ba00dfa)
SUMMARY
Moving specific logic to
PostgresEngineSpec
to allow other specs (Redshift
) to have more control over how we create the engine since the options keys are not the same for individualsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION