Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changes the Select component to preserve the search value when selecting #23869

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Sets autoClearSearchValue={false} in the Select component to to preserve the search value when selecting. Only applies when mode is set to multiple.

Resolves #23315

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-28.at.14.03.59.mov

TESTING INSTRUCTIONS

Make sure the search value is preserved when selecting.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #23869 (70b47be) into master (594d3e0) will not change coverage.
The diff coverage is n/a.

❗ Current head 70b47be differs from pull request most recent head cfffc3f. Consider uploading reports for the commit cfffc3f to get more accurate results

@@           Coverage Diff           @@
##           master   #23869   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        1938     1938           
  Lines       74972    74972           
  Branches     8141     8141           
=======================================
  Hits        51067    51067           
  Misses      21826    21826           
  Partials     2079     2079           
Flag Coverage Δ
javascript 54.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/components/Select/AsyncSelect.tsx 88.46% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 90.41% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

rusackas commented May 1, 2023

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

@rusackas Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

@michael-s-molina michael-s-molina merged commit f2fc4a0 into apache:master May 2, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk select for filters
4 participants