Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove feature flag for tags on Dashboard API for Tags #23909

Merged
merged 1 commit into from
May 2, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 2, 2023

SUMMARY

Dashboard Tags don't appear on Dashboard CRUD View for superset, here's a PR to allow the columns to be exposed but the client will manage whether they appear

Clipboard 2023-13-04 at 4 40 01 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #23909 (be37c6b) into master (a8e02cd) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head be37c6b differs from pull request most recent head 383482b. Consider uploading reports for the commit 383482b to get more accurate results

@@            Coverage Diff             @@
##           master   #23909      +/-   ##
==========================================
- Coverage   68.08%   67.95%   -0.13%     
==========================================
  Files        1939     1939              
  Lines       75012    75008       -4     
  Branches     8154     8154              
==========================================
- Hits        51072    50974      -98     
- Misses      21857    21951      +94     
  Partials     2083     2083              
Flag Coverage Δ
hive ?
mysql 78.81% <ø> (?)
postgres 78.88% <ø> (+<0.01%) ⬆️
presto ?
python 82.37% <ø> (-0.27%) ⬇️
sqlite 77.40% <ø> (+<0.01%) ⬆️
unit 52.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/api.py 92.54% <ø> (+0.43%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 3528f41 into master May 2, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix-tags-dashboard-3 branch March 26, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants