Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts #23917

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented May 3, 2023

SUMMARY

This PR introduces a control to set the Secondary Y-axis bounds for Mixed charts.

It's out of the scope of this PR to improve the categorization and display positions of the controls but we should definitely do it in a follow-up PR because it's not very user friendly. @kasiazjc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-05-03.at.11.57.17.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina marked this pull request as ready for review May 3, 2023 14:07
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #23917 (6458d25) into master (3c381c5) will increase coverage by 0.09%.
The diff coverage is 93.33%.

❗ Current head 6458d25 differs from pull request most recent head ac527ef. Consider uploading reports for the commit ac527ef to get more accurate results

@@            Coverage Diff             @@
##           master   #23917      +/-   ##
==========================================
+ Coverage   68.08%   68.17%   +0.09%     
==========================================
  Files        1939     1941       +2     
  Lines       75007    75212     +205     
  Branches     8154     8158       +4     
==========================================
+ Hits        51066    51277     +211     
+ Misses      21858    21852       -6     
  Partials     2083     2083              
Flag Coverage Δ
javascript 54.46% <60.86%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 56.52% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...set-frontend/src/components/Select/AsyncSelect.tsx 88.46% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 90.41% <ø> (ø)
...nd/src/explore/components/RunQueryButton/index.tsx 100.00% <ø> (ø)
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/setup/setupFormatters.ts 0.00% <ø> (ø)
superset-frontend/src/types/bootstrapTypes.ts 100.00% <ø> (ø)
superset/cli/native_filters.py 0.00% <ø> (ø)
superset/dashboards/api.py 92.54% <ø> (+0.43%) ⬆️
... and 28 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina changed the title feat: Adds an option to Mixed Chart to make Y axes independent of each other feat: Adds an additional Y-axis bounds control to Mixed Chart May 3, 2023
@michael-s-molina michael-s-molina changed the title feat: Adds an additional Y-axis bounds control to Mixed Chart feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts May 3, 2023
@rusackas
Copy link
Member

rusackas commented May 4, 2023

If we're talking about the UI of this thing, I'd love to see all the Query A and Query B controls in tabs :)

Co-authored-by: Evan Rusackas <evan@preset.io>
@rusackas
Copy link
Member

rusackas commented May 4, 2023

Not sure if there are any tests that should be cloned as well for good measure, or storybook tweaks, but the logic seems fine to me!

@michael-s-molina michael-s-molina merged commit b4371f6 into apache:master May 5, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants