-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts #23917
feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts #23917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23917 +/- ##
==========================================
+ Coverage 68.08% 68.17% +0.09%
==========================================
Files 1939 1941 +2
Lines 75007 75212 +205
Branches 8154 8158 +4
==========================================
+ Hits 51066 51277 +211
+ Misses 21858 21852 -6
Partials 2083 2083
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If we're talking about the UI of this thing, I'd love to see all the Query A and Query B controls in tabs :) |
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Evan Rusackas <evan@preset.io>
Not sure if there are any tests that should be cloned as well for good measure, or storybook tweaks, but the logic seems fine to me! |
SUMMARY
This PR introduces a control to set the Secondary Y-axis bounds for Mixed charts.
It's out of the scope of this PR to improve the categorization and display positions of the controls but we should definitely do it in a follow-up PR because it's not very user friendly. @kasiazjc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-05-03.at.11.57.17.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION