Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(celery worker): install unzip & wget #23919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

endrinmusa
Copy link

@endrinmusa endrinmusa commented May 3, 2023

SUMMARY

I stumbled upon this issue that the worker was not able to install chrome and chromedriver because wget and unzip were missing. So adding them during worker init will fix the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before adding:
image

After adding:
image

TESTING INSTRUCTIONS

Simply try to init the worker with Kubernetes config, with apt install unzip wget -y added to the command: part.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

I stumbled upon this issue that the worker was not able to install chrome and chromedriver because wget and unzip were missing. So adding them during worker init will fix the issue.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless to me, but I'll ping @mistercrunch, who knows more about this area than I do... should wget and unzip be part of some requirements/dependencies file or is installing them manually at this phase more sensible?

@rusackas
Copy link
Member

Just needs a bit of a rebase, otherwise... sorry this didn't get attention sooner! We're trying to get better about keeping PRs on track.

@mistercrunch
Copy link
Member

Some people really like having super lean images for production, bloating images has impact on speed of autoscaling/deploys/... It feels we should layer this in a dev or fat image if at all. Seems unzip/wget would support in-docker troubleshooting/debugging, but why can't you just apt-get while in the image? Also realizing we have a fair amount of Dockerfile-type content in docs which seems off, that stuff should be in actual Dockerfiles and layered properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants