Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): Split service templates into separate files #23923

Merged
merged 1 commit into from
May 8, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented May 3, 2023

SUMMARY

The PR splits Service resource definitions into separate files according to Helm Best Practices Guide:

  • Each resource definition should be in its own template file.

Also service-account.yaml renamed to serviceaccount.yaml according to:

  • Template file names should use dashed notation (my-example-configmap.yaml), not camelcase.

The PR does not change any functionality of the chart.

TESTING INSTRUCTIONS

The following command creates superset, superset-flower and superset-ws services.

helm template superset helm/superset --set supersetCeleryFlower.enabled=true --set supersetWebsockets.enabled=true

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dnskr
Copy link
Contributor Author

dnskr commented May 8, 2023

@craig-rueda Could you please have a look the PR?

@craig-rueda craig-rueda merged commit 9681d85 into apache:master May 8, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants