Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate /superset/add_slices #23936

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 4, 2023

SUMMARY

Found no references on superset-frontend for this old endpoint. Theres no exact replacement but the same can be achieved by calling /api/v1/chart/<id> PUT and adding the chart to a dashboard (no bulk update)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #23936 (f4ab69f) into master (93789b8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f4ab69f differs from pull request most recent head b38482d. Consider uploading reports for the commit b38482d to get more accurate results

@@           Coverage Diff           @@
##           master   #23936   +/-   ##
=======================================
  Coverage   68.18%   68.18%           
=======================================
  Files        1941     1941           
  Lines       75241    75241           
  Branches     8158     8158           
=======================================
  Hits        51306    51306           
  Misses      21852    21852           
  Partials     2083     2083           
Flag Coverage Δ
hive 53.17% <100.00%> (ø)
mysql 78.90% <100.00%> (ø)
postgres 78.97% <100.00%> (ø)
presto 53.09% <100.00%> (ø)
python 82.75% <100.00%> (ø)
sqlite 77.50% <100.00%> (ø)
unit 52.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.35% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dpgaspar dpgaspar merged commit cfc70ea into apache:master May 8, 2023
@dpgaspar dpgaspar deleted the danielgaspar/sc-70273/migrate-add-slices-int-dashboard-id branch May 8, 2023 08:28
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants