-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate /superset/add_slices #23936
chore: deprecate /superset/add_slices #23936
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23936 +/- ##
=======================================
Coverage 68.18% 68.18%
=======================================
Files 1941 1941
Lines 75241 75241
Branches 8158 8158
=======================================
Hits 51306 51306
Misses 21852 21852
Partials 2083 2083
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Found no references on
superset-frontend
for this old endpoint. Theres no exact replacement but the same can be achieved by calling/api/v1/chart/<id>
PUT and adding the chart to a dashboard (no bulk update)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION