Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: helm template to set init job annotations #23941

Merged
merged 3 commits into from
May 18, 2023

Conversation

ybudweiser
Copy link
Contributor

@ybudweiser ybudweiser commented May 4, 2023

SUMMARY

Provides a flexible option for adding annotations to the init-db job. By default the existing helm hooks will be added, however a user can now replace the annotations with hooks compatible with argo cd.

TESTING INSTRUCTIONS

  1. helm template superset .
  2. helm install superset .

ADDITIONAL INFORMATION

ADDITIONAL INFORMATION

Note: This removes the helm value of init.helmHook and replaces it with a more flexible option
If you have previously disabled the helmHook to continue with it disabled you will need to replace it with init.jobAnnotations = {}

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@@ -621,7 +621,9 @@ init:
- "-c"
- ". {{ .Values.configMountPath }}/superset_bootstrap.sh; . {{ .Values.configMountPath }}/superset_init.sh"
enabled: true
helmHook: true
jobAnnotations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just call this key annotations

Copy link
Contributor Author

@ybudweiser ybudweiser May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another key called podAnnotations below so i kept it specific.
hooks need to go on the job annotation
Is that ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see. Nevermind :)

@rusackas
Copy link
Member

rusackas commented May 4, 2023

Running CI 🤞

@ybudweiser ybudweiser changed the title template to set init job annotations build: helm template to set init job annotations May 4, 2023
@dnskr
Copy link
Contributor

dnskr commented May 4, 2023

@ybudweiser Install and run helm-docs to fix the issue in CI.

@villebro villebro merged commit ea5d0cc into apache:master May 18, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support helm chart to be installed by Argo CD
6 participants