Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart-controls): Show detailed data type tooltip when hovering type icon #23970

Merged
merged 10 commits into from
May 11, 2023
Merged

feat(chart-controls): Show detailed data type tooltip when hovering type icon #23970

merged 10 commits into from
May 11, 2023

Commits on May 8, 2023

  1. Added tooltip for column datatype in chart

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 8, 2023
    Configuration menu
    Copy the full SHA
    78c3714 View commit details
    Browse the repository at this point in the history

  2. Added column datatype tooltip node creation logic

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 8, 2023
    Configuration menu
    Copy the full SHA
    e436e0a View commit details
    Browse the repository at this point in the history

  3. prettier issue fix in ColumnOption.tsx file

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 8, 2023
    Configuration menu
    Copy the full SHA
    df0a224 View commit details
    Browse the repository at this point in the history

  4. prettier issue fix in Update labelUtils.tsx

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 8, 2023
    Configuration menu
    Copy the full SHA
    4043aa2 View commit details
    Browse the repository at this point in the history

  5. Added tests for column datatype tooltip

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 8, 2023
    Configuration menu
    Copy the full SHA
    253be94 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Removed unused variables

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 9, 2023
    Configuration menu
    Copy the full SHA
    d8ac7d9 View commit details
    Browse the repository at this point in the history

  2. Removed function parameter which was not required

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 9, 2023
    Configuration menu
    Copy the full SHA
    44584a7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Align tooltip arrow to point to icon of column datatype

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 10, 2023
    Configuration menu
    Copy the full SHA
    0ee7d41 View commit details
    Browse the repository at this point in the history

  2. Rendering tooltip conditionally

    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 10, 2023
    Configuration menu
    Copy the full SHA
    9f30967 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Refactoring as per review comments 

    Improved conditional statement
    @ved-kashyap-samsung
    ved-kashyap-samsung authored May 11, 2023
    Configuration menu
    Copy the full SHA
    c5a6c8c View commit details
    Browse the repository at this point in the history