Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): adding JavaScript to CodeQL config #23974

Merged
merged 1 commit into from
May 10, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 8, 2023

SUMMARY

Adds Javascript code scanning to the CodeQL config. Let's see what happens!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title chore: adding JavaScript to CodeQL config chore(actions): adding JavaScript to CodeQL config May 8, 2023
@rusackas rusackas requested a review from dpgaspar May 8, 2023 22:16
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #23974 (f8131a0) into master (724fd82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23974   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files        1941     1941           
  Lines       75242    75242           
  Branches     8157     8157           
=======================================
  Hits        51308    51308           
  Misses      21851    21851           
  Partials     2083     2083           
Flag Coverage Δ
hive 53.17% <ø> (ø)
javascript 54.49% <ø> (ø)
mysql 78.90% <ø> (ø)
postgres 78.97% <ø> (ø)
presto 53.09% <ø> (ø)
python 82.75% <ø> (ø)
sqlite 77.50% <ø> (ø)
unit 52.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 20d439a into master May 10, 2023
@rusackas rusackas deleted the scan-javascript-with-codeql branch May 10, 2023 14:08
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants