Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deprecate DND feature flags #23981

Merged
merged 4 commits into from
May 10, 2023
Merged

chore: Deprecate DND feature flags #23981

merged 4 commits into from
May 10, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented May 9, 2023

SUMMARY

This PR:

  • removes ENABLE_DND_WITH_CLICK_UX feature flag and consolidates its behaviour with ENABLE_EXPLORE_DRAG_AND_DROP ff
  • deprecates ENABLE_EXPLORE_DRAG_AND_DROP (true by default - to be removed in 4.0)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@kgabryje kgabryje requested a review from rusackas May 9, 2023 07:33
@kgabryje kgabryje added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #23981 (a82646e) into master (d96b72d) will increase coverage by 0.03%.
The diff coverage is 80.00%.

❗ Current head a82646e differs from pull request most recent head f7f881b. Consider uploading reports for the commit f7f881b to get more accurate results

@@            Coverage Diff             @@
##           master   #23981      +/-   ##
==========================================
+ Coverage   68.18%   68.21%   +0.03%     
==========================================
  Files        1941     1941              
  Lines       75287    75274      -13     
  Branches     8177     8166      -11     
==========================================
+ Hits        51332    51346      +14     
+ Misses      21860    21839      -21     
+ Partials     2095     2089       -6
Flag Coverage Δ
hive 53.17% <ø> (ø)
javascript 54.55% <80.00%> (+0.01%) ⬆️
mysql 78.90% <ø> (?)
postgres 78.97% <ø> (ø)
presto 53.09% <ø> (ø)
python 82.75% <ø> (+0.04%) ⬆️
sqlite 77.50% <ø> (ø)
unit 52.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 58.33% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 42.97% <ø> (+0.69%) ⬆️
...controls/DndColumnSelectControl/DndSelectLabel.tsx 72.72% <ø> (-2.28%) ⬇️
superset/config.py 92.02% <ø> (ø)
superset/explore/permalink/commands/create.py 90.90% <ø> (ø)
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 46.93% <66.66%> (+3.07%) ⬆️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 49.56% <100.00%> (+1.70%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje
fix mypy fail
87b9afb 
fix mypy fail

fix mypy fail
@kgabryje
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@kgabryje Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.

villebro
villebro approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor wording/translation comment

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx Outdated
@@ -244,8 +244,7 @@ export const dndGranularitySqlaControl: typeof dndSeriesControl = {
default: (c: Control) => c.default,
clearable: false,
canDelete: false,
ghostButtonText: t('Drop temporal column here'),
clickEnabledGhostButtonText: t('Drop a temporal column here or click'),
ghostButtonText: t('Drop temporal column here or click'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was leaving the "a" out intentional? I'm ok both ways but if we change the string existing translations will break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye! Definitely not intentional

@kgabryje kgabryje merged commit 7757b61 into apache:master May 10, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@eschutho eschutho Awaiting requested review from eschutho

@geido geido Awaiting requested review from geido

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@rusackas rusackas Awaiting requested review from rusackas

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgabryje @villebro @mistercrunch @michael-s-molina