Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Department names fixed for CountryMap of France #23988

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

xavier-GitHub76
Copy link
Contributor

SUMMARY

Just a fix for department name :

  • Haut-Rhin
  • Seine-et-Marne

TESTING INSTRUCTIONS

Add a CountryMap Chart
Select France as country
Show name of these departements

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #23988 (9360883) into master (d96b72d) will increase coverage by 0.76%.
The diff coverage is 73.87%.

❗ Current head 9360883 differs from pull request most recent head b75b018. Consider uploading reports for the commit b75b018 to get more accurate results

@@            Coverage Diff             @@
##           master   #23988      +/-   ##
==========================================
+ Coverage   68.18%   68.94%   +0.76%     
==========================================
  Files        1941     1901      -40     
  Lines       75287    73898    -1389     
  Branches     8177     8175       -2     
==========================================
- Hits        51332    50951     -381     
+ Misses      21860    20834    -1026     
- Partials     2095     2113      +18     
Flag Coverage Δ
javascript 55.77% <73.87%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/superset-ui-chart-controls/src/constants.ts 100.00% <ø> (ø)
...ackages/superset-ui-chart-controls/src/fixtures.ts 100.00% <ø> (ø)
...chart-controls/src/shared-controls/dndControls.tsx 58.33% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...erset-ui-chart-controls/src/utils/columnChoices.ts 100.00% <ø> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <ø> (ø)
...i-core/src/color/colorSchemes/sequential/common.ts 100.00% <ø> (ø)
.../superset-ui-core/src/models/ExtensibleFunction.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/types/Datasource.ts 100.00% <ø> (ø)
... and 29 more

... and 522 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit a9c4472 into apache:master Jul 25, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 26, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 13, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants