-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cross filters scoping #24020
feat: Cross filters scoping #24020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24020 +/- ##
==========================================
+ Coverage 68.20% 68.28% +0.08%
==========================================
Files 1941 1951 +10
Lines 75287 75401 +114
Branches 8177 8183 +6
==========================================
+ Hits 51347 51486 +139
+ Misses 21845 21813 -32
- Partials 2095 2102 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks amazing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass comments - I'll do some testing shortly.
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
Show resolved
Hide resolved
superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py
Outdated
Show resolved
Hide resolved
7ce9627
to
c7a5764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested to work as expected
SUMMARY
Add cross-filter scoping feature (previously removed in PR #23216).
In order to set cross filter scoping, user can open the scoping modal either from the configuration menu in upper left corner of the dashboard or from a options menu of any chart that's compatible with cross filters.
User can set a global scoping which will be a default scoping for every chart that supports cross filters. The global scoping can be overriden for each chart individually.
If a custom scoping for a chart is removed, the chart reverts to using the global scoping
Please take note that cross filter will NOT be applied to charts that have datasources incompatible with the emitter chart (target chart uses a different datasource which does not share a common column name with the emitter chart), even if they are in scope of the emitter chart!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-05-12.at.14.56.25.mov
TESTING INSTRUCTIONS
DASHBOARD_CROSS_FILTERS
feature flagADDITIONAL INFORMATION
Has associated issue:
Required feature flags:
DASHBOARD_CROSS_FILTERS
Changes UI
Includes DB Migration (follow approval process in SIP-59)
10+: 0.21 s
100+: 0.14 s
1000+: 0.22 s
Introduces new feature or API
Removes existing feature or API
CC @kasiazjc @yousoph